[v2.10] SQL cache backports#435
Merged
Merged
Conversation
Signed-off-by: Silvio Moioli <silvio@moioli.net>
* Change indexed fields according to https://github.com/rancher/rancher/issues/48256wq Signed-off-by: Silvio Moioli <silvio@moioli.net> * Fix typo --------- Signed-off-by: Silvio Moioli <silvio@moioli.net>
* bump lasso to include pull rancher#111 Signed-off-by: Silvio Moioli <silvio@moioli.net> * Make IsListWatchable public to be reused in other packages Signed-off-by: Silvio Moioli <silvio@moioli.net> * Let lasso know whether a type is watchable upon requesting a cache Signed-off-by: Silvio Moioli <silvio@moioli.net> * Adapt existing tests Signed-off-by: Silvio Moioli <silvio@moioli.net> * Add a test to check watchability is detected correctly Signed-off-by: Silvio Moioli <silvio@moioli.net> --------- Signed-off-by: Silvio Moioli <silvio@moioli.net>
* Update indexed fields * Add .status.currentReplicas
ericpromislow
requested changes
Jan 9, 2025
Contributor
ericpromislow
left a comment
ericpromislow
left a comment
There was a problem hiding this comment.
The gvk list is getting large, and would be more maintainable if it's kept in alphabetical order
Contributor
|
@ericpromislow Considering these are backports of already merged commits/PRs, I think it's okay as is and can be fixed in a future PR (in |
Signed-off-by: Silvio Moioli <silvio@moioli.net>
Contributor
Author
Contributor
Author
|
Please merge directly if you are OK with the changes |
tomleb
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #400, #430, #284, #433, #437
All straight cherry-picks.