Skip to content

fix: resolve dependency chain issues #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: resolve dependency chain issues #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion modules/network_load_balancer/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ resource "aws_security_group_rule" "external_ingress" {
}

resource "aws_lb" "new" {
count = local.create
count = local.create
depends_on = [
aws_eip.created,
]
name = local.name
internal = false
load_balancer_type = "network"
Expand Down Expand Up @@ -83,6 +86,9 @@ resource "aws_lb" "new" {
}

resource "aws_lb_target_group" "created" {
depends_on = [
aws_lb.new,
]
for_each = (local.create == 1 ? local.access_info : {})
name = each.value.target_name
port = each.value.port
Expand All @@ -101,6 +107,9 @@ resource "aws_lb_target_group" "created" {
}

resource "aws_lb_listener" "created" {
depends_on = [
aws_lb.new,
]
for_each = (local.create == 1 ? local.access_info : {})
load_balancer_arn = aws_lb.new[0].arn
port = each.value.port
Expand Down