Skip to content

fix: remove incorrect note and add new #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: remove incorrect note and add new #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@ WARNING! The subnets argument must not be derived from an apply time resource.

## Recent Changes

- IPv6 is having issues due to missing the "primary" ipv6 flag in the AWS provider.
https://github.com/hashicorp/terraform-provider-aws/pull/36425
This PR fixes the issue, but in the mean time I am setting the subnet to "ipv6_native".
- Dependency chain resolution
I was getting some intermittent issues attempting to destroy EIPs while also destroying the load balancer.
The error was something like "error disassociating EC2 address".
I believe AWS is automatically disassociating the EIP when destroying the load balancer.
To resolve I am setting the explicit dependency for the load balancer on the EIP addresses.
This should force the EIPs to be deleted before the load balancer.

- IPv6 only and Dualstack Support BREAKING CHANGES!
A few interface changes were necessary to inform the module about options which are now ambiguous.
Expand Down