Skip to content

fix: update notes on ingress #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2024
Merged

fix: update notes on ingress #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## Recent Changes

- Manage external access

You can now add ingress from external addresses by cidr and port.
This will generate security group rules with 'from' and 'to' having the port number specified.
The input is a map of port to list of CIDRs, eg. `{"443" = ["1.1.1.1/32","2.2.2.2/32"], "6443" = ["3.3.3.3/24"]}`.

- BREAKING CHANGES!

While adding the loadbalancer and domain to this module it kinda seems like the ssh key shouldn't be included.
Expand All @@ -13,13 +19,6 @@
3. Subnets inputs needed to change to incorporate high availability
With this is a massive change in the interface, this is a major break from the previous version, but I believe necessary for its growth.

- Skip Runner IP

By default this module will create a security group which allows the ip of the client running terraform ingress and egress access.
This enables users to configure servers after they are created, but is not always wanted.
The new variable "skip_runner_ip" will prevent the creation of that security group, further securing the project.
This functionality enables air-gapped production projects.

## AWS Access

The first step to using the AWS modules is having an AWS account,
Expand Down