test: core capi bump on turtles upgrade#1965
Merged
Merged
Conversation
salasberryfin
added
kind/enhancement
salasberryfin
changed the title
salasberryfin
force-pushed
the
test-capi-bump
branch
4 times, most recently
from
541ab02 to
e6f7c0c
Compare
salasberryfin
changed the title
`chart-upgrade` E2E suite includes a step to verify upgrading to a Turtles version that ships with a newer version of CAPI. A custom Turtles image and chart are built for this new test scenario. Signed-off-by: Carlos Salas <carlos.salas@suse.com>
The cleanup workflow after E2E finishes fails if there are multiple images that match the tag. Now that we use more than one image for E2E, we need it to support deletion of multiple images. Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
test-capi-bump
branch
from
e6f7c0c to
0dfb270
Compare
alexander-demicev
previously approved these changes
Jan 2, 2026
The existing configuration would only succeed to find the image if it is available locally. This used to work because the image building action was embedded in the `test-e2e` make action on the image would always be locally available. Using `docker manifest inspect` it will also work if the image is available remotely. Signed-off-by: Carlos Salas <carlos.salas@suse.com>
alexander-demicev
approved these changes
Jan 2, 2026
Contributor
Author
|
This should be ready to be merged once the long E2E is confirmed to pass after the most recent changes: https://github.com/rancher/turtles/actions/runs/20662890136 |
Contributor
Author
|
E2E long are now passing: https://github.com/rancher/turtles/actions/runs/20662890136 |
This was referenced Feb 6, 2026
This was referenced Feb 13, 2026
This was referenced Mar 6, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kind/enhancement
area/testing
What this PR does / why we need it:
This PR adds coverage for testing bumping the version of core CAPI when upgrading Turtles. The scenario is the following:
v1.10.6.v1.10.7.Turtles is upgraded as a system chart by upgrading Rancher as whole and using a new version of Turtles chart which points to a new image. The chart embeds the manifest for the updated version of core CAPI (for which the fetch script is used) and the image is built with a clusterctl configuration that points to the new version of core CAPI and to the upstream registry, as there will be no forked versions of a non-pinned version of the controller.
Testing this requires having a custom procedure for building this alternate image and chart:
./test/e2e/data. This is parsed and used for building the custom image.This new test is added to the existing
chart-upgradesuite as it aligns with its overall scope.Long E2E test run: https://github.com/rancher/turtles/actions/runs/20662890136
Which issue(s) this PR fixes:
Fixes #1819
Special notes for your reviewer:
While working on these changes I noticed that there were steps in the E2E process that were duplicated in existing GitHub workflows:
make test-e2e. However,make test-e2eitself calls the image building action.The PR tries to address these issues but further optimization (and overall cleanup) should be applied in our current
Makefileand automations.Checklist: