fix: Fix secret reference to Rancher cloud credential#1982
Merged
Conversation
anmazzotti
requested changes
Jan 5, 2026
Contributor
anmazzotti
left a comment
There was a problem hiding this comment.
All good, but the schema is not updated accordingly.
Contributor
salasberryfin
left a comment
There was a problem hiding this comment.
Thanks @yiannistri. LGTM pending the schema update.
anmazzotti
approved these changes
Jan 6, 2026
salasberryfin
approved these changes
Jan 6, 2026
This was referenced Feb 6, 2026
This was referenced Feb 13, 2026
This was referenced Mar 6, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the secret reference to Rancher cloud credential.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1978
Special notes for your reviewer:
Running
results in
In this case the namespace that will be used to lookup the secret is
cattle-global-data.Running
results in
Checklist: