fix: Add provider images in values.yaml#2019
Conversation
…them in rancher-images.txt
|
To be able to test this end-to-end:
UPDATE from thehejik: To make it work, one have to put data.json from kdm to |
salasberryfin
left a comment
There was a problem hiding this comment.
Thanks @yiannistri.
We should probably have a follow up to haveupdatecli syncing provider versions in values.yaml with what we have in config-prime.yaml. One less configuration to take care of.
|
@salasberryfin shouldn't this instead replace config-prime.yaml entirely? also considering this chart is following the same release lifecycle of Turtles |
|
In that case I think we'd have to build the Turtles image with the values taken from the chart's |
|
No, just use CAPIProvider.spec.version. There is no reason to hardcode the versions if we have to also put them here. This also implies Turtles does not need separate builds anymore. |
anmazzotti
left a comment
There was a problem hiding this comment.
Thank you @yiannistri
What this PR does / why we need it:
Adding provider images in
values.yamlfor the purpose of including them inrancher-images.txtduring a Rancher release.Which issue(s) this PR fixes:
Fixes #2017
Special notes for your reviewer:
This PR once merged, needs to be backported to
release/v0.25.Checklist: