This repository was archived by the owner on Mar 25, 2024. It is now read-only.
[2.4] [Fix] Updated api bool fields with default=true to *bool, to be usable from client#1083
Merged
Merged
Conversation
Contributor
|
@rawmind0 this will need changes in rancher and rke because both repos use these fields as bool, so we can't merge this till the other two PRs are also ready for merging |
rawmind0
force-pushed
the
apiBool
branch
2 times, most recently
from
994d60e to
e155429
Compare
rawmind0
changed the title
This was referenced May 20, 2020
Contributor
Author
|
@mrajashree created related PRs rancher/rancher#27169 and rancher/rke#2064 |
Contributor
|
@rawmind0 thanks, can we also test this doesn't break things on upgrade from 2.3 branch? |
Contributor
Author
|
PR rebased to address conflicts. Upgrade has been tested successfully from rancher v2.3.6, to v2.4.2, to this changes on 2.4 branch. |
mrajashree
previously approved these changes
May 21, 2020
dramich
previously approved these changes
May 26, 2020
…om client. Go types files
mrajashree
previously approved these changes
May 28, 2020
dramich
reviewed
May 28, 2020
…om client. Go generated files
dramich
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates api bool fields with default=true to *bool, to be usable from client:
IgnoreDockerVersiononrke_typesUseInternalIPAddressonNodeCommonParamsandIgnoreDaemonSetsonNodeDrainInputonmachine_typesCompressonFluentForwarderConfigonlogging_typesTLSonSMTPConfigonalerting_typesThis is related with golang
Marshalfunction fromencoding/jsonthat omits false bool ifomitemptyis set, golang/go#13284 (comment)Fix issues https://github.com/terraform-providers/terraform-provider-rancher2/issues/41, https://github.com/terraform-providers/terraform-provider-rancher2/issues/264, https://github.com/terraform-providers/terraform-provider-rancher2/issues/356 and rancher/rancher#25321