This repository was archived by the owner on Mar 25, 2024. It is now read-only.
Conversation
rmweir
force-pushed
the
wait-timeout-fix
branch
2 times, most recently
from
08569c2 to
336da48
Compare
rmweir
force-pushed
the
wait-timeout-fix
branch
4 times, most recently
from
830a7b6 to
eb4cdaa
Compare
cbron
reviewed
Jul 22, 2019
cbron
approved these changes
Jul 22, 2019
Contributor
cbron
left a comment
cbron
left a comment
There was a problem hiding this comment.
LGTM besides that one comment
rmweir
force-pushed
the
wait-timeout-fix
branch
2 times, most recently
from
d3fb011 to
b4fa16c
Compare
Added timeout and wait fields to apps. Prior, there was no way for rancher to utilize helm's timeout and wait flags. Now, values for these flags can be read from and assigned to their respective app fields.
Contributor
|
lgtm |
1 similar comment
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.