Update eks node group asg desired and minsize to 0#4887
Merged
catherineluse merged 1 commit intorancher:masterfrom Aug 30, 2022
Merged
Update eks node group asg desired and minsize to 0#4887catherineluse merged 1 commit intorancher:masterfrom
catherineluse merged 1 commit intorancher:masterfrom
Conversation
catherineluse
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#38698
rancher/dashboard#6731
Proposed changes
We are updating the AWS SDK to version 1.44 and with that, comes the ability to scale a node group in an EKS cluster to 0 nodes. The rancher ui won't allow you to set a 0 value for
desiredSizeandminSizein the node group config so this change updates the ui to allow that.