Eks custom node role#4936
Merged
mantis-toboggan-md merged 2 commits intorancher:masterfrom Jan 10, 2023
Merged
Conversation
mantis-toboggan-md
force-pushed
the
eks-custom-node-role
branch
from
173a9ca to
be38c1a
Compare
codyrancher
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7755 #7756 #7754
The nodeRole field should use the Arn value, see comment here. Additionally, aws role data may be paginated...afaict the
IsTruncated/Markerpattern is used across this version of the aws sdk so making this change to the more generaldescribeResourcefunction seems safe.In addition to depaginating data when relevant, I've increased the max number of items that may be returned to the maximum allowed, 1000, which lets us fetch all our roles in one request; the easiest way to test the depagination code is probably to change MaxItems to a smaller number.