RKE1 pod security admission support#4946
Merged
nwmac merged 5 commits intorancher:masterfrom Jan 23, 2023
Merged
Conversation
codyrancher
previously approved these changes
Jan 23, 2023
nwmac
requested changes
Jan 23, 2023
Member
nwmac
left a comment
There was a problem hiding this comment.
One change - we want to show the PSA Template drop down if the k8s version is >= 1.23
Member
|
@codyrancher Can you review my changes - I pushed a commit so that PSA support is enabled for >= 1.23 (which is when it is introduced). PSP removed in 1.25 and code updated as PSP support overlaps with PSA support now. |
codyrancher
approved these changes
Jan 23, 2023
nwmac
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rancher/dashboard#7575
This PR adds PSA support during RKE1 configuration. This is only available for kubernetes versions >=1.23.0. Users creating clusters with versions <1.25 should have the same experience as before, with the addition of a banner informing them that psp support will be disabled in later versions.
Creating a >=1.25.0 cluster
rancherKubernetesEngineConfig.services.kubeApi.podSecurityConfigurationUpgrading to >=1.25.0 from a version with PSP support
rke1 templates
testing
When I run the ember UI locally websockets do not work correctly: this makes testing cluster provisioning difficult (the ui waits for a message saying the cluster resource is created before creating node pools; this wont work without websockt support). I got around this by building the ember UI and running rancher-in-docker with that custom-built UI replacing the one bundled in the rancher/rancher image using the --mount command. If you don't want to go throught hat ping on slack and I'll give you login details for a testing setup.