Fix labels not being saved on hosted providers#4950
Merged
nwmac merged 3 commits intorancher:masterfrom Jan 23, 2023
Merged
Conversation
codyrancher
reviewed
Jan 19, 2023
codyrancher
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses rancher/dashboard#7631
This PR fixes the above issue.
We are not sending the labels or annotations for hosted providers.
This PR adds an extra arg to the save method, so that we can determine if the labels or annotations have changed, and only send those it they have.
Tested with an Azure AKS cluster.