clear defaultPodSecurityPolicyTemplateId when disable psp support is selected during rke1 provisioning#4980
Merged
mantis-toboggan-md merged 1 commit intorancher:masterfrom Mar 6, 2023
Conversation
clear config.defaultPodSecurityPolicyTemplateId when disable psp support is selected
codyrancher
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rancher/dashboard#8304
Changing the 'pod security policy support' radio to 'disabled' changes
rancherKubernetesEngineConfig.services.kubeApi.podSecurityPolicy- to fully disable PSP support we also need to clear out thedefaultPodSecurityPolicyTemplateIdI also noticed a problem with one of the warning banners around upgrading while working on this; previously I was checking for the presence of
podSecurityPolicyTemplateProjectBindingsin the cluster: the actual resource that causes issues on attempting to upgrade to >=1.25 is policy.podSecurityPolicy. Not sure if I've implemented this correctly: that resource doesn't appear to be available via norman so I've queried the relevant cluster's kubernetes api endpoint instead.