Skip to content

AKS MaxSurge: Address QA feedback#5019

Merged
nwmac merged 1 commit intorancher:masterfrom
nwmac:aks-updates
May 11, 2023
Merged

AKS MaxSurge: Address QA feedback#5019
nwmac merged 1 commit intorancher:masterfrom
nwmac:aks-updates

Conversation

@nwmac
Copy link
Member

@nwmac nwmac commented May 11, 2023

This PR addresses feedback for rancher/dashboard#8073.

It:

  • Allows maxSurge to be editable after cluster creation
  • Sets defaulr for maxSurge to 1
  • Adds validation for maxSurge so it is either a percentage (1-100) or an integer greater than 1

@nwmac nwmac added this to the 2.7.next2 milestone May 11, 2023
@nwmac nwmac requested a review from mantis-toboggan-md May 11, 2023 04:45
@nwmac nwmac self-assigned this May 11, 2023
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nwmac nwmac merged commit 11b75d8 into rancher:master May 11, 2023
@nwmac nwmac deleted the aks-updates branch May 11, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants