fix agent config cpu req unit formatting#5022
Merged
mantis-toboggan-md merged 1 commit intorancher:masterfrom May 15, 2023
Merged
fix agent config cpu req unit formatting#5022mantis-toboggan-md merged 1 commit intorancher:masterfrom
mantis-toboggan-md merged 1 commit intorancher:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rancher/dashboard#8871
rancher/dashboard#8864
This PR updates the unit parsing/formatting for cpu requests to use the same utility function used for other mCPU inputs around the Ember UI. The previous solution implemented runs into problems w/ floating point arithmetic accuracy, eg when the value inputted is
1001mthis is parsed to1.001and1.001*1000returns1000.99....