Skip to content

Conversation

@rohitsakala
Copy link
Member

@rohitsakala rohitsakala commented Feb 19, 2025

Issue rancher/rancher#49156

Implemented a part of it as I faced that specific problem.

@rohitsakala rohitsakala requested a review from a team as a code owner February 19, 2025 22:13
@crobby
Copy link
Collaborator

crobby commented Feb 20, 2025

Quick question here, not necessarily a change request: for webhook, we get norman pulled-in as an indirect dep. Do we also need to protect against indirect norman bumps to major/minor versions with this?

@tomleb
Copy link
Contributor

tomleb commented Feb 20, 2025

Quick question here, not necessarily a change request: for webhook, we get norman pulled-in as an indirect dep. Do we also need to protect against indirect norman bumps to major/minor versions with this?

I'm not sure what the behavior of renovate is wrt indirect dependencies, however looking at the list of renovate PR, I don't see one targeting norman alone. As such, it's likely we don't need any rules here for this.

Copy link
Collaborator

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable enhancement. I'm not sure how to "try" this without merge and try, but it seems like a sensible thing to try. If the experiment goes well here, we can expand it to other repos.

Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's try it out and we'll see.

@rohitsakala rohitsakala merged commit 7dddff6 into rancher:main Feb 20, 2025
2 checks passed
@rohitsakala
Copy link
Member Author

This seems to be working. Renovate closed #684.

@tomleb
Copy link
Contributor

tomleb commented Feb 20, 2025

@rohitsakala yes, I see #697 is still opened though 🤔

gomod-k8sio-dependencies is this group: https://github.com/rancher/renovate-config/blob/release/default.json#L304. I wonder if we have to do:

    {
      "enabled": false,
      "groupName": "gomod-k8sio-dependencies"
    },

to turn it off

@rohitsakala
Copy link
Member Author

rohitsakala commented Feb 20, 2025

@tomleb I created this #699

Yes and I also see this open #680

Would this PR cover "groupName": "gomod-k8sio-dependencies" ?

@tomleb
Copy link
Contributor

tomleb commented Feb 20, 2025

@rohitsakala maybe, we should be able to test it locally. Looking at my bash history, I have the following command I was using for testing renovate:

docker run --rm -v $PWD:/repo:ro -e LOG_LEVEL=debug   -e GITHUB_COM_TOKEN="$(gh auth token)"  -it --workdir /repo renovate/renovate:slim renovate --platform=local  | tee ok.log

IIRC it has some limitations but in the past I was able to see what renovate was going to do.

@rohitsakala
Copy link
Member Author

@tomleb Yes, we need to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants