Skip to content

Correct syntax for matchPackagePatterns #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

Correct syntax for matchPackagePatterns #699

merged 1 commit into from
Feb 20, 2025

Conversation

@rohitsakala
Copy link
Member

@rohitsakala rohitsakala commented Feb 20, 2025

@rohitsakala rohitsakala requested a review from a team as a code owner February 20, 2025 18:11
@rohitsakala rohitsakala mentioned this pull request Feb 20, 2025
Merged
@rohitsakala rohitsakala changed the title Use regex matching for matchPackageNames Use regex matching for matchPackagePatterns Feb 20, 2025
@rohitsakala rohitsakala force-pushed the main branch 4 times, most recently from 87afc22 to 643a1e7 Compare February 20, 2025 18:57
@rohitsakala rohitsakala changed the title Use regex matching for matchPackagePatterns Correct syntax for matchPackageNames Feb 20, 2025
@rohitsakala rohitsakala force-pushed the main branch 10 times, most recently from d5e28bd to 6cc4093 Compare February 20, 2025 19:58
@rohitsakala rohitsakala changed the title Correct syntax for matchPackageNames Correct syntax for matchPackagePatterns Feb 20, 2025
@rohitsakala
Copy link
Member Author

rohitsakala commented Feb 20, 2025 •
edited
Loading

Only for main branch

After using this PR, I ran renovate --dry-run and output is

 INFO: DRY-RUN: Would commit files to branch renovate/golang.org-x-exp-digest (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/golang.org-x-exp-digest)
 INFO: DRY-RUN: Would commit files to branch renovate/go-1.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/go-1.x)
 INFO: DRY-RUN: Would commit files to branch renovate/docker-build-push-action-6.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/docker-build-push-action-6.x)
 INFO: DRY-RUN: Would commit files to branch renovate/registry.suse.com-bci-golang-1.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/registry.suse.com-bci-golang-1.x)

Before this PR, the output was

 INFO: DRY-RUN: Would commit files to branch renovate/github.com-rancher-rancher-pkg-apis-digest (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/github.com-rancher-rancher-pkg-apis-digest)
 INFO: DRY-RUN: Would commit files to branch renovate/golang.org-x-exp-digest (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/golang.org-x-exp-digest)
 INFO: DRY-RUN: Would commit files to branch renovate/k8s.io-cri-client-0.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/k8s.io-cri-client-0.x)
 INFO: DRY-RUN: Would commit files to branch renovate/k8s.io-dynamic-resource-allocation-0.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/k8s.io-dynamic-resource-allocation-0.x)
 INFO: DRY-RUN: Would commit files to branch renovate/k8s.io-endpointslice-0.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/k8s.io-endpointslice-0.x)
 INFO: DRY-RUN: Would commit files to branch renovate/k8s.io-externaljwt-0.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/k8s.io-externaljwt-0.x)
 INFO: DRY-RUN: Would commit files to branch renovate/go-1.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/go-1.x)
 INFO: DRY-RUN: Would commit files to branch renovate/docker-build-push-action-6.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/docker-build-push-action-6.x)
 INFO: DRY-RUN: Would commit files to branch renovate/gomod-sigsk8sio-dependencies (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/gomod-sigsk8sio-dependencies)
 INFO: DRY-RUN: Would commit files to branch renovate/registry.suse.com-bci-golang-1.x (repository=rohitsakala/webhook, baseBranch=main, branch=renovate/registry.suse.com-bci-golang-1.x)

crobby
crobby approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks worthy of a try.

@rohitsakala rohitsakala merged commit 74f7335 into rancher:main Feb 20, 2025
2 checks passed
This was referenced Feb 21, 2025
Merged
Merged
@rohitsakala rohitsakala mentioned this pull request Mar 11, 2025
Closed
This was referenced Mar 28, 2025
Closed
Merged
This was referenced Jul 28, 2025
Merged
Merged
This was referenced Nov 19, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crobby crobby crobby approved these changes

@tomleb tomleb tomleb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohitsakala @crobby @tomleb