feat(adkg/acss): distribute both feldman & pedersen shares#255
Merged
AnomalRoil merged 5 commits intomainfrom Jan 28, 2026
Merged
feat(adkg/acss): distribute both feldman & pedersen shares#255AnomalRoil merged 5 commits intomainfrom
AnomalRoil merged 5 commits intomainfrom
Conversation
azixus
force-pushed
the
fix/adkg/mvba
branch
from
be27473 to
4070e1e
Compare
AnomalRoil
approved these changes
Jan 16, 2026
AnomalRoil
temporarily deployed
to
github-pages
GitHub Actions
Inactive
AnomalRoil
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous iteration of the HTADKG, I had mistakenly removed the Feldman verifiable secret share, replacing it entirely by Pedersen VSS shares.
This was a mistake as it rendered the ECDH coin toss impossible. We needed proper ECDH keys in the form$X = xG$ for the protocol to succeed, which was impossible to obtain using Pedersen's polynomial commitments.
This PR adds back a Feldman share to the ACSS. We now execute 1 Feldman VSS, and 1 Pedersen VSS in the case of the standard ADKG, and 1 Feldman + 2 Pedersens for the high-threshold variant, instead of using only Pedersen shares.
I hadn't noticed that earlier since the coin toss is only executed during disagreements on the set of shares to use, which was less likely to occur due to the ABA bug in #254.