Various fixes with bsi module policy#522
Merged
randombit merged 2 commits intorandombit:masterfrom Jul 4, 2016
securitykernel:policy-build-fixes
Merged
Various fixes with bsi module policy#522randombit merged 2 commits intorandombit:masterfrom securitykernel:policy-build-fixes
randombit merged 2 commits intorandombit:masterfrom
securitykernel:policy-build-fixes
Conversation
Current coverage is 81.84%@@ master #522 diff @@
==========================================
Files 307 307
Lines 23534 23537 +3
Methods 0 0
Messages 0 0
Branches 51 51
==========================================
+ Hits 19264 19265 +1
- Misses 4245 4247 +2
Partials 25 25
|
randombit
added a commit
that referenced
this pull request
Jul 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#ifdefaround ECIES tests requiring the ISO 18033 KDF (leads to test failures if the KDF is not part of the build, as it is only a test dependency, not an implementation dependency)par_hashdependency totlsmoduleHandshake_Hash::final()(led to crashes in TLS <1.2 tests ifpar_hashis not part of the build)With this patch,
./configure.py --module-policy=bsi --enable-modules="tls"now successfully compiles and tests run fine. Maybe we could add this configuration to CI to prevent regressions?Updated: Removed unused
kdf2dependency fromtlsmodule (which is prohibited in BSI module policy anyway)