Skip to content

Various fixes with bsi module policy#522

Merged
randombit merged 2 commits intorandombit:masterfrom
securitykernel:policy-build-fixes
Jul 4, 2016
Merged

Various fixes with bsi module policy#522
randombit merged 2 commits intorandombit:masterfrom
securitykernel:policy-build-fixes

Conversation

@securitykernel
Copy link
Copy Markdown
Collaborator

@securitykernel securitykernel commented Jul 4, 2016

  • Add KDFs permitted/prohibited by BSI to BSI module policy
  • Add ECIES, ECKCDSA to BSI module policy
  • Add appropriate #ifdef around ECIES tests requiring the ISO 18033 KDF (leads to test failures if the KDF is not part of the build, as it is only a test dependency, not an implementation dependency)
  • Add missing par_hash dependency to tls module
  • Check for valid hash function in Handshake_Hash::final() (led to crashes in TLS <1.2 tests if par_hash is not part of the build)

With this patch, ./configure.py --module-policy=bsi --enable-modules="tls" now successfully compiles and tests run fine. Maybe we could add this configuration to CI to prevent regressions?

Updated: Removed unused kdf2 dependency from tls module (which is prohibited in BSI module policy anyway)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 4, 2016

Current coverage is 81.84%

Merging #522 into master will decrease coverage by <.01%

@@             master       #522   diff @@
==========================================
  Files           307        307          
  Lines         23534      23537     +3   
  Methods           0          0          
  Messages          0          0          
  Branches         51         51          
==========================================
+ Hits          19264      19265     +1   
- Misses         4245       4247     +2   
  Partials         25         25          

Powered by Codecov. Last updated by 696a831...8d66358

@randombit randombit merged commit 8d66358 into randombit:master Jul 4, 2016
randombit added a commit that referenced this pull request Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants