Avoid copying std::function objects needlessly in the test_throws infra#5329
Merged
Avoid copying std::function objects needlessly in the test_throws infra#5329
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes the test_throws test infrastructure by changing how std::function objects are passed to avoid unnecessary copying. The change switches from passing std::function by const reference to pass-by-value with move semantics, which eliminates an extra copy when lambdas are passed as temporary objects.
Changes:
- Updated function signatures to take
std::function<void()>by value instead of const reference - Added
std::move()calls when constructingThrowExpectationsobjects to enable move semantics
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/tests.h | Updated declarations and template implementations of test_throws and test_no_throw to use pass-by-value and std::move() |
| src/tests/tests.cpp | Updated non-template implementations of test_throws and test_no_throw to use pass-by-value and std::move() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.