Fix: Amalgamated Windows Builds with PKCS 11#5486
Merged
Merged
Conversation
The windows header defines a macro "interface" for structs. Paramerters must not be named like this.
randombit
approved these changes
Mar 25, 2026
Owner
randombit
left a comment
randombit
left a comment
There was a problem hiding this comment.
Thanks for investigating this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #5482
The windows header defines a macro interface for structs:
windows.h includes ole2.h includes objbase.h includes combaseapi.h which defines:
Unfortunately, I named some parameters "interface", which causes trouble in amalgamation builds. I have no idea how this wasn't catched by our CI.