Skip to content

fix: set approval log fields based on workflow state#3

Merged
ravibharathi656 merged 1 commit into
mainfrom
feat/approval-log
Mar 27, 2026
Merged

fix: set approval log fields based on workflow state#3
ravibharathi656 merged 1 commit into
mainfrom
feat/approval-log

Conversation

@ravibharathi656
Copy link
Copy Markdown
Contributor

Summary:

  • Added shg_approval_by and shg_approved_on fields to NominationForm to capture SHG-level approval.
  • Refactored set_approval_log() to use a state-to-prefix mapping (SHG Proposed, VO Approved, CLF Approved), eliminating repetitive if/elif blocks and making it easy to extend with new states.
  • Replaced raw current_user (email) with get_fullname() for more readable approval records.
  • Moved approval log logic from on_update to before_save to avoid duplicate writes.

@ravibharathi656 ravibharathi656 merged commit fcf7814 into main Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant