ValueList cannot actually contain another ValueList

Author: henryk

fints/formals.py

@@ -56,9 +56,6 @@ def __len__(self):
                 if isinstance(val, Container):
                     if val.is_unset():
                         continue
-                elif isinstance(val, ValueList):
-                    if len(val) == 0:
-                        continue
                 elif val is None:
                     continue
                 retval = i+1
@@ -161,7 +158,7 @@ def _check_value_length(self, value):
     def render(self, value):
         if value is None:
             return ""
-        
+
         return self._render_value(value)
 
 class TypedField(Field, SubclassesMixin):

tests/test_formals.py

@@ -298,6 +298,23 @@ def test_sequence_repr():
 
     assert repr(s) == 'SegmentSequence([])'
 
+def test_valuelist_repr():
+    class A(Container):
+        a = NumericField(max_count=3)
+
+    i1 = A()
+    assert repr(i1.a) == "[]"
+
+def test_empty_list():
+    class A(Container):
+        a = NumericField(max_count=3)
+
+    i1 = A()
+    assert len(i1.a) == 0
+
+    i2 = A(a=[None])
+    assert len(i2.a) == 0
+
 def test_segmentheader_short():
     h = SegmentHeader('HNHBS', 5, 1)