exploit/multi/local/periodic_script_persistence: Unset DefaultTarget #20611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exploit/multi/local/periodic_script_persistence
module sets an invalid target index within theDefaultTarget
option.metasploit-framework/modules/exploits/multi/local/periodic_script_persistence.rb
Lines 37 to 46 in 55bb277
Targets are zero-indexed. As such,
4
is an invalid target index.This caused issues with the Local Exploit Suggester (#20609).
I'm not sure why
4
(presumably3
) was chosen as the default target. This target does not perform automatic targeting and is not a safe default target for all platforms.This PR removes the default
DefaultTarget
value, forcing the operator to knowingly and intentionally chose atarget
.