This repository was archived by the owner on Feb 5, 2026. It is now read-only.
Add logback encoder support and use UTF-8 encoding explicitly#11
Merged
sbialkowski-r7 merged 5 commits intorapid7:masterfrom Dec 18, 2019
Merged
Add logback encoder support and use UTF-8 encoding explicitly#11sbialkowski-r7 merged 5 commits intorapid7:masterfrom
sbialkowski-r7 merged 5 commits intorapid7:masterfrom
Conversation
Contributor
|
Hi @rillgen, seems that this repo uses spaces, not tabs, this causes a massive diff, would you be able to reformat? |
Contributor
Author
Hi @sbialkowski-r7 thanks for pointing that out, I reformatted the code using spaces. |
jcolgan-r7
reviewed
Dec 18, 2019
jcolgan-r7
reviewed
Dec 18, 2019
Co-Authored-By: James Colgan <30832432+jcolgan-r7@users.noreply.github.com>
jcolgan-r7
approved these changes
Dec 18, 2019
rjacobs-r7
approved these changes
Dec 18, 2019
Contributor
rjacobs-r7
left a comment
rjacobs-r7
left a comment
There was a problem hiding this comment.
Can someone make sure to apply Git tags and submit to Maven Central after merge?
Contributor
|
@rillgen Thanks so much for contributing to our repo, we really appreciate it! |
maquilanti-r7
pushed a commit
to maquilanti-r7/r7insight_java
that referenced
this pull request
Jan 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using this library to push our logs using logback, and would like to send them encoded in JSON format so that we can push custom logging attributes and use them for filtering.
There are logback encoders that do this such as elastic's
LogstashEncoderbut unfortunately the r7insight library lacks support for these as when anEncoderis defined, it assumes that it is aPatternLayoutEncoder. This patch aims to provide generic support for anyEncoder.