Skip to content

[4.x] Fix response typehint in boot#1194

Merged
royduin merged 1 commit into4.xfrom
bugfix/response-type
Feb 17, 2026
Merged

[4.x] Fix response typehint in boot#1194
royduin merged 1 commit into4.xfrom
bugfix/response-type

Conversation

@Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Feb 16, 2026

As it turns out, the Laravel RedirectResponse does not inherit the Laravel Response class. Instead, it extends the Symfony RedirectResponse which only inherits the Symfony Response class.

This means that we can't use the base Response class here. As the setPrivate function comes from the base Symfony class we can just use that instead. This sidesteps needing to define all the possible Response types we might get.

@Jade-GG Jade-GG marked this pull request as ready for review February 16, 2026 12:13
@royduin royduin merged commit 9a9c259 into 4.x Feb 17, 2026
22 of 24 checks passed
@royduin royduin deleted the bugfix/response-type branch February 17, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants