[5.x] Use joins for attribute option values instead of a relation#1203
Merged
[5.x] Use joins for attribute option values instead of a relation#1203
Conversation
Member
|
Looking at the screenshots, the option names are missing and are replaced by their id instead |
… into feature/use-joins-lol
… into feature/use-joins-lol
indykoning
previously approved these changes
Feb 23, 2026
royduin
reviewed
Feb 24, 2026
| DB::raw('IF(ISNULL(ANY_VALUE(eav_attribute_option_value.value)), null, JSON_ARRAYAGG(eav_attribute_option_value.value)) AS option_values'), | ||
| ]) | ||
| ->leftJoin('eav_attribute_option', function (JoinClause $join) use ($model) { | ||
| return $join->on('eav_attribute_option.attribute_id', "{$model->getTable()}.attribute_id") |
Member
There was a problem hiding this comment.
Maybe use the getQualifiedColumn here?
Jade-GG
force-pushed
the
feature/use-joins-lol
branch
from
af563e8 to
4633f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dramatically reduces the amount of models loaded. Performance-wise, this reduces loading time from ~250ms to ~240ms, for a performance gain of ~4%.
Interestingly, according to the debug bar there is no significant change in the amount of memory used. Most of this is probably made neglegible by how much overhead Laravel requires.