Merged
Conversation
indykoning
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: BORDEX-1356
We found that there was a race condition in the listing: The
ais-hitscomponent got loaded in too early, causing it to load in without any customized filters or sorting first, only changing to be correct after the filters loaded in.This PR makes it so the hits component will not show up before the first request has been completed, which (in my testing) solves this issue. Instantsearch will always end up doing a request, even without
ais-hits, so this change cannot cause the component to not show up at all.Note that this does not solve the issue of several unnecessary requests being made to elasticsearch, it just makes sure there's no jumps in the items that are shown on listing pages.