Fixed AttributeDecimal could not be converted to float

[indykoning]

This PR fixes AttributeDecimal could not be converted to float

After the addition of the value, label, etc. functions on the attributes, this change here seems to have been forgotten.

This causes errors on the indexers and PDPs when products do not have their price in the product_price index, which seems to be the case when products are out of stock.

[Jade-GG]

This vs changing this line to always retrieve the value? Might be cleaner that way? Or maybe that's taking away too much in case you want to use the label instead of the value in an Attribute cast?

[indykoning]

Both would absolutely work so it'd be a matter of preference.
I personally prefer it like this to make the code more explicit and easier to understand for newcomers and tooling over extending the magic

[Jade-GG]

Both would absolutely work so it'd be a matter of preference. I personally prefer it like this to make the code more explicit and easier to understand for newcomers and tooling over extending the magic

I agree, it's definitely better to keep things explicit to avoid magic.

My only issue with it would be that it means you don't always know when you have to do ->value without first checking whether you're getting an AbstractAttribute (e.g. name) or a direct column/joined value (e.g. sku). I can see this causing some issues in the future. But we'll have to see.