Removed todos, and added refs to the rest#1248
Merged
Conversation
indykoning
commented
Apr 2, 2026
Comment on lines
-30
to
-32
| // TODO: Are we filtering this on the frontend? | ||
| // As "searchable" will be used for the | ||
| // listing and the search... |
Member
Author
There was a problem hiding this comment.
We are filtering this on the frontend
indykoning
commented
Apr 2, 2026
Comment on lines
-10
to
-11
| // TODO: Maybe create a model for this and cache it? | ||
| // But most likely it's never going to change... |
Member
Author
There was a problem hiding this comment.
But most likely it's never going to change
It's not worth it to turn this into a model with more queries
indykoning
commented
Apr 2, 2026
Comment on lines
-290
to
-295
| // TODO: Double check the prices with the indexer. | ||
| // We should index all customer group prices | ||
| // as we can only verify that on the | ||
| // frontend. But currently this | ||
| // is also loading all prices | ||
| // for just a product page. |
Member
Author
There was a problem hiding this comment.
We are actually using this on the frontend now, on PDPs as well
Line 22 in 92e46c3
Jade-GG
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: RAP-1859