[5.x] Fix track events being duplicated#1259
Merged
Merged
Conversation
Jade-GG
changed the title
indykoning
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: RAP-1878
Two issues at play here. Firstly, this eventlistener never gets removed, which caused it to re-run on every new Turbo navigation. The requests actually piled up the more products you visited, causing things to eventually break.
Secondarily, as it turns out turbo actually loads the page twice. Once a stale "preview" version from cache, then another once the page actually loads. This is great for pagespeed, but it also means this script got executed twice on cached pages.
Luckily, we can easily check whether the page is cached by checking if
data-turbo-previewis set on the documentElement.This does beg the question... do we need to wrap anything else with this kind of check?