[5.x] Add heartbeat to keep CSRF tokens alive#1274
Merged
Conversation
Member
Collaborator
Author
|
Looks like that package does a similar thing but just has some methods to make it not run on certain pages. It's also using classic ajax requests. Seems both unnecessary and overkill in our case. It'll end up doing the same thing as this, except as an unnecessary extra dependency with more complexity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: RAP-1888
This PR adds an empty route under the
webmiddleware to keep the CSRF token alive, which it then calls every 15 minutes. This should significantly reduce the issue where people are doing requests with invalid CSRF tokens.