Skip to content

Feature/compact header footer in checkout#3

Merged
royduin merged 1 commit intorapidez:masterfrom
claudio-ferraro:feature/compact-header-footer-in-checkout
Jan 12, 2021
Merged

Feature/compact header footer in checkout#3
royduin merged 1 commit intorapidez:masterfrom
claudio-ferraro:feature/compact-header-footer-in-checkout

Conversation

@claudio-ferraro
Copy link
Member

No description provided.

@royduin
Copy link
Member

royduin commented Jan 11, 2021

There are multiple approaches here:

  1. The current approach by having a custom header/footer for the checkout and header/footer sections which can be changed. Drawbacks; multiple header/footer files and "complexity"?
  2. Checkout layout, so a app.blade.php and a checkout.blade.php with their own header/footer files. Drawbacks; duplication? Also multiple header/footer files?
  3. If/else statements in the existing header/footer files to show/hide things partially. Drawbacks; if the header/footer is completely different it doesn't make sense.

The end user can implement whatever they want after all, so to keep things simple I think option 3 is better for now to have in the core as the differences in the header/footer are so minimal.

Thoughts? How do we want the header/footer to look like in the checkout with the demo? Is that going to be completely different?

@royduin royduin merged commit c4e1ac0 into rapidez:master Jan 12, 2021
Jade-GG added a commit that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants