[6.x] Minimize memory usage for retrieving product rewrite URLs#180
Merged
[6.x] Minimize memory usage for retrieving product rewrite URLs#180
Conversation
kevinmeijer97
previously approved these changes
Jan 23, 2026
BobWez98
previously approved these changes
Feb 10, 2026
Member
|
Chunking rows to reduce memory usage is exactly what https://laravel.com/docs/12.x/eloquent#chunking-using-lazy-collections is built for. Perhaps we can use that, your current fix does reduce memory usage. But it doesn't solve the inefficient memory usage problem. With another bulk of products, or lower memory you may run into it again. Doing it lazily will go in chunks of 1000 by default and remove that chunk from memory before moving on to the next 1000 |
Member
|
There is a conflict 😇 and do we need this on other branches? 6.x = Rapidez v4 |
This was referenced Feb 13, 2026
Jade-GG
changed the title
Collaborator
Author
Fixed and yes, also fixed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some projects this command ended up breaking as it was trying to get ~23000 products with all the rewrites which took a lot of memory.
In this PR I've attempted to mitigate this by doing smaller queries that each individually retrieve just the relevant entity IDs and then the relevant rewrite URLs. This also somewhat cleans up and speeds up the code as a result.
ETA: Adding this PR as a patch into the project where this issue occurred has fixed it there.