[WIP] Support converting cuda array interface objects with masks to pylibcudf Columns#18320
Closed
Matt711 wants to merge 6 commits intorapidsai:branch-25.04from
Closed
[WIP] Support converting cuda array interface objects with masks to pylibcudf Columns#18320Matt711 wants to merge 6 commits intorapidsai:branch-25.04from
Matt711 wants to merge 6 commits intorapidsai:branch-25.04from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Matt711
commented
Mar 19, 2025
| return cp.asarray(np_2darray) | ||
|
|
||
|
|
||
| class CuPyArrayWithMask(cp.ndarray): |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| class CuPyArrayWithMask(cp.ndarray): | |
| # There no built-in way to create a cupy array with a | |
| # mask. See https://github.com/cupy/cupy/issues/2225 | |
| class CuPyArrayWithMask(cp.ndarray): |
Contributor
Author
|
Closing this for now as mask support is not a priority |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15132 and #18214. I think this PR and #18311 should be sufficient for Curator to replace their existing logic to convert cupy arrays to list columns with
from_pylibcudfandfrom_ndarray. Eg.Checklist