Prepare cuvs for removal of deprecated raft apis by aamijar · Pull Request #1610 · rapidsai/cuvs

aamijar · 2025-12-03T08:45:17Z

Resolves #1601, Resolves #1491

What does this PR do?

Removes lingering unused raft headers that will be deprecated such as #include <raft/neighbors/refine.cuh>, #include <raft/distance/distance_types.hpp>, etc.
Exposes build_dendrogram_host which is used by cuml. cuml currently uses the raft version. The raft version was moved to cuvs but it is not in the public interface.
This PR also removes the legacy spectral related files.

copy-pr-bot · 2025-12-03T08:45:20Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

jinsolp

Thanks @aamijar , leaving a few comments.

Also, do you think you can fix the related docs as well? I think this is the only place that has outdated docs including raft files, but might be a good idea to check on your end as well : )

cuvs/cpp/src/neighbors/ball_cover.cuh

Lines 29 to 32 in ba67db1

    
            *  #include <raft/core/resources.hpp> 
        
            *  #include <raft/neighbors/ball_cover.cuh> 
        
            *  #include <raft/distance/distance_types.hpp> 
        
            *  using namespace raft::neighbors;

jinsolp · 2025-12-04T20:38:46Z

cpp/CMakeLists.txt

@@ -405,7 +405,6 @@ if(NOT BUILD_CPU_ONLY)
    src/distance/distance.cu


shouldn't we add agglomerative.cu in the cmakelists?

jinsolp · 2025-12-04T21:06:36Z

Also, can we try pinning the raft branch to make sure it's working well on that branch (to ensure we haven't missed anything)

copy-pr-bot · 2025-12-06T08:28:26Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

aamijar · 2025-12-08T22:11:16Z

Hi @jinsolp, I think I have addressed your comments

bdice · 2025-12-08T22:18:38Z

cpp/cmake/thirdparty/get_raft.cmake

Reminder to revert before merging.

jinsolp

Approving with minor suggestions on the docs!

cpp/src/neighbors/ball_cover.cuh

Co-authored-by: Jinsol Park <jinsolp@nvidia.com>

divyegala · 2025-12-10T19:09:18Z

cpp/include/cuvs/cluster/agglomerative.hpp

+void build_dendrogram_host(raft::resources const& handle,
+                           const int64_t* rows,
+                           const int64_t* cols,
+                           const float* data,
+                           size_t nnz,
+                           int64_t* children,
+                           float* out_delta,
+                           int64_t* out_size);
+


cuVS only allows for mdspan based public APIs.

Addressed in 59bd5e5

Can you also drop the _host suffix? That's just an implementation detail.

Addressed in e163b2a

jinsolp · 2025-12-13T02:13:17Z

/merge

Resolves #7554, Depends on rapidsai/cuvs#1610 (CI won't pass until this is merged) What does this PR do? 1. Removes lingering **unused** raft headers that will be deprecated such as `#include <raft/spatial/knn/knn.cuh>`, `#include <raft/distance/distance.cuh>`, etc. 2. ~~Updates to raft::memory_type_from_pointer instead of the deprecated raft::spatial::knn::detail::utils::pointer_residency.~~ 3. Removes `metric_processor` from `knn.hpp` and `knn.cu`. The only special metric processing needed is for correlation distance which we can handle in `knn.cu` instead of using the class from `processing.cuh` from raft. The cosine distance is supported in ivf_flat and ivf_pq in cuvs so we do **not** need to use the innerproduct metric and special processing that was there before. 4. Uses `build_dendrogram_host` from cuvs instead of raft. Authors: - Anupam (https://github.com/aamijar) Approvers: - Victor Lafargue (https://github.com/viclafargue) URL: #7561

…ghbors/` apis (#2885) Supersedes #2813 and #2878 Resolves #2737 and Resolves #2872 Marking as **breaking** to get more eyes on this and mitigate risk. This PR should not break downstream libraries as long as we merge the updates to them first: rapidsai/cuvs#1610, rapidsai/cuml#7561. I've found a usage of breaking api in FAISS here: https://github.com/facebookresearch/faiss/blob/1721ebff6de6ed5a8481302123479be9d85059a2/faiss/gpu/GpuDistance.cu#L46. https://github.com/facebookresearch/faiss/blob/5b19fca3f057b837ac898af52a8eb801c4744892/faiss/gpu/impl/CuvsFlatIndex.cu#L34 What does this PR do? 1. Removes `cluster/`, `distance/`, `neighbors/` (except `detail/faiss_select/`), `sparse/neighbors/`, `spatial/` 2. Removes unused includes that will be deprecated such as `#include <raft/distance/distance.cuh>`, `#include <raft/spatial/knn/knn.cuh>`, etc. 3. Removes legacy lanczos solver (`linalg/lanczos`, `sparse/linalg/lanczos` old functions in `sparse/solver/lanczos`) and removes legacy spectral apis (`spectral/ ` except modularity_maximization and partition which are metrics used by cugraph) 4. Removes corresponding gtests, raft_runtime, and bench files. Authors: - Anupam (https://github.com/aamijar) Approvers: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet) URL: #2885

Resolves rapidsai#7554, Depends on rapidsai/cuvs#1610 (CI won't pass until this is merged) What does this PR do? 1. Removes lingering **unused** raft headers that will be deprecated such as `#include <raft/spatial/knn/knn.cuh>`, `#include <raft/distance/distance.cuh>`, etc. 2. ~~Updates to raft::memory_type_from_pointer instead of the deprecated raft::spatial::knn::detail::utils::pointer_residency.~~ 3. Removes `metric_processor` from `knn.hpp` and `knn.cu`. The only special metric processing needed is for correlation distance which we can handle in `knn.cu` instead of using the class from `processing.cuh` from raft. The cosine distance is supported in ivf_flat and ivf_pq in cuvs so we do **not** need to use the innerproduct metric and special processing that was there before. 4. Uses `build_dendrogram_host` from cuvs instead of raft. Authors: - Anupam (https://github.com/aamijar) Approvers: - Victor Lafargue (https://github.com/viclafargue) URL: rapidsai#7561

raft-deprecated-apis

309038a

github-project-automation bot moved this to Todo in Vector Search, ML, & Data Mining Release Board Dec 3, 2025

github-project-automation bot added this to Vector Search, ML, & Data Mining Release Board Dec 3, 2025

aamijar self-assigned this Dec 3, 2025

aamijar moved this from Todo to Done in Vector Search, ML, & Data Mining Release Board Dec 3, 2025

aamijar moved this from Done to In Progress in Vector Search, ML, & Data Mining Release Board Dec 3, 2025

aamijar added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Dec 3, 2025

aamijar and others added 2 commits December 3, 2025 09:11

clean up

dc24bf5

Merge branch 'main' into raft-deprecated-apis

053005e

aamijar mentioned this pull request Dec 3, 2025

Prepare cuml for removal of deprecated raft apis rapidsai/cuml#7561

Merged

aamijar marked this pull request as ready for review December 3, 2025 09:15

aamijar requested review from a team as code owners December 3, 2025 09:15

aamijar added 2 commits December 3, 2025 09:32

restore gram.cu

87036a0

restore gram.cu

fdc57f4

aamijar mentioned this pull request Dec 3, 2025

Remove neighbors/, cluster/, distance/, spatial/, sparse/neighbors/ apis rapidsai/raft#2885

Merged

aamijar added 3 commits December 3, 2025 17:33

rerun CI

1e7afa7

rerun CI

416281a

rerun CI

4bdb92b

jinsolp requested changes Dec 4, 2025

View reviewed changes

pin raft

b22e9c6

Merge branch 'main' into raft-deprecated-apis

cde8d9b

aamijar force-pushed the raft-deprecated-apis branch from 64c26fb to cde8d9b Compare December 6, 2025 08:29

aamijar added 3 commits December 6, 2025 09:19

add agglomerative.cu to cmake

f8a7875

docs update

e725854

rerun CI

98e7d12

bdice approved these changes Dec 8, 2025

View reviewed changes

cpp/cmake/thirdparty/get_raft.cmake

Copy link

Contributor

bdice Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to revert before merging.

aamijar reacted with thumbs up emoji

jinsolp approved these changes Dec 9, 2025

View reviewed changes

cpp/src/neighbors/ball_cover.cuh Outdated Show resolved Hide resolved

cpp/src/neighbors/ball_cover.cuh Outdated Show resolved Hide resolved

aamijar and others added 2 commits December 8, 2025 16:29

Update cpp/src/neighbors/ball_cover.cuh

813f6e9

Co-authored-by: Jinsol Park <jinsolp@nvidia.com>

Update cpp/src/neighbors/ball_cover.cuh

bff5ee4

Co-authored-by: Jinsol Park <jinsolp@nvidia.com>

divyegala requested changes Dec 10, 2025

View reviewed changes

aamijar and others added 4 commits December 11, 2025 01:27

mdpsan update

59bd5e5

Merge branch 'main' into raft-deprecated-apis

6081461

remove host suffix

e163b2a

unpin raft

ddb2a9b

divyegala approved these changes Dec 11, 2025

View reviewed changes

Merge branch 'main' into raft-deprecated-apis

455b7a2

rapids-bot bot merged commit e72dd2a into rapidsai:main Dec 13, 2025
92 checks passed

github-project-automation bot moved this from In Progress to Done in Vector Search, ML, & Data Mining Release Board Dec 13, 2025

	* #include <raft/core/resources.hpp>
	* #include <raft/neighbors/ball_cover.cuh>
	* #include <raft/distance/distance_types.hpp>
	* using namespace raft::neighbors;

		@@ -405,7 +405,6 @@ if(NOT BUILD_CPU_ONLY)
		src/distance/distance.cu

Conversation

aamijar commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot bot commented Dec 3, 2025

Uh oh!

jinsolp left a comment

Choose a reason for hiding this comment

Uh oh!

jinsolp Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

jinsolp commented Dec 4, 2025

Uh oh!

copy-pr-bot bot commented Dec 6, 2025

Uh oh!

aamijar commented Dec 8, 2025

Uh oh!

bdice Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

jinsolp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

divyegala Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

aamijar Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

divyegala Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

aamijar Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

jinsolp commented Dec 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aamijar commented Dec 3, 2025 •

edited

Loading