Skip to content

Shorten the Test Duration of test_cagra_ace.py#1640

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
julianmi:shorten-ace-python-tests
Dec 15, 2025
Merged

Shorten the Test Duration of test_cagra_ace.py#1640
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
julianmi:shorten-ace-python-tests

Conversation

@julianmi
Copy link
Contributor

I was made aware that the CAGRA ACE Python test was taking long during CI. This shortens the test duration by reducing the test combinations. Instead, variations of npartitions, ef_construction, and hierarchy are tested separately to keep the test coverage high. I have also aligned the test defaults with the existing CAGRA test.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! We should always aim for maximum coverage but GPU test runtime is also a significant constraint for team velocity and CI resource management.

@tfeher tfeher added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 15, 2025
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tfeher
Copy link
Contributor

tfeher commented Dec 15, 2025

/merge

@rapids-bot rapids-bot bot merged commit 0df2781 into rapidsai:main Dec 15, 2025
158 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Development

Successfully merging this pull request may close these issues.

4 participants