Fix libclang download for Rust, CUDA initialization for C tests#1652
Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom Dec 18, 2025
Merged
Conversation
Searching in `/opt/conda` for libclang was causing it to sometimes find libclang in the package directory instead of the environment. Search the environment only. Also initialize CUDA architectures for C tests in case `$CUDAARCHS` is set to `RAPIDS`.
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
divyegala
approved these changes
Dec 17, 2025
Member
Author
|
These changes were already tested at https://github.com/rapidsai/cuvs/actions/runs/20316882452/job/58364555189?pr=1405, so they definitely work. |
bdice
approved these changes
Dec 17, 2025
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Approving with a small question. Maybe just needs docs clarification in rapids-cmake.
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this pull request
Dec 17, 2025
Mention that `enable_language()` can also be used. Raised in rapidsai/cuvs#1652 (comment).
7 tasks
Member
|
/merge |
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
rapids-bot bot
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Dec 18, 2025
Mention that `enable_language()` can also be used. Raised in rapidsai/cuvs#1652 (comment). Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) URL: #956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching in
/opt/condafor libclang was causing it to sometimes find libclang in the package directory instead of the environment. Search the environment only.Also initialize CUDA architectures for C tests in case
$CUDAARCHSis set toRAPIDS.