Skip to content

Use token.rapids.nvidia.com when issuing S3 bucket creds in devcontainers#2047

Open
trxcllnt wants to merge 2 commits intorapidsai:mainfrom
trxcllnt:fea/use-rapids-token-service-in-devcontainers
Open

Use token.rapids.nvidia.com when issuing S3 bucket creds in devcontainers#2047
trxcllnt wants to merge 2 commits intorapidsai:mainfrom
trxcllnt:fea/use-rapids-token-service-in-devcontainers

Conversation

@trxcllnt
Copy link
Copy Markdown
Contributor

Set AWS_IDP_URL and update AWS_ROLE_ARN to use token.rapids.nvidia.com

@trxcllnt trxcllnt requested a review from a team as a code owner April 30, 2026 17:33
@trxcllnt trxcllnt requested a review from KyleFromNVIDIA April 30, 2026 17:33
@trxcllnt trxcllnt added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Apr 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2af53ef5-f49c-4dc4-9379-345ddf391f4c

📥 Commits

Reviewing files that changed from the base of the PR and between e5d1fc8 and ecc2c11.

📒 Files selected for processing (1)
  • .devcontainer/Dockerfile

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated development environment credential handling for build-cache tooling (switched role used for sccache).
    • Added an identity-provider URL environment variable to support token retrieval.
    • Updated SPDX copyright years (2023–2026).

Walkthrough

The .devcontainer/Dockerfile updates sccache AWS credential configuration by replacing the IAM role ARN from nv-gha-token-sccache-devs to rapids-token-sccache-devs, adds an AWS_IDP_URL environment variable set to https://token.rapids.nvidia.com, and updates the SPDX copyright year to 2023-2026.

Changes

Cohort / File(s) Summary
AWS Credential Configuration
./.devcontainer/Dockerfile
Replaced AWS_ROLE_ARN role name (nv-gha-token-sccache-devsrapids-token-sccache-devs), added AWS_IDP_URL="https://token.rapids.nvidia.com", and updated SPDX year to 2023-2026.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating devcontainers to use token.rapids.nvidia.com for S3 bucket credentials.
Description check ✅ Passed The description directly relates to the changeset by explaining the AWS_IDP_URL and AWS_ROLE_ARN updates for token.rapids.nvidia.com integration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 6/10 reviews remaining, refill in 21 minutes and 34 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@trxcllnt trxcllnt added non-breaking Introduces a non-breaking change and removed non-breaking Introduces a non-breaking change labels Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants