Add SECURITY.md#2139
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis PR establishes a security vulnerability reporting process by introducing a SECURITY.md disclosure guide aligned with NVIDIA PSIRT, assigning ops team ownership via CODEOWNERS, and configuring CI workflows to exclude documentation-only changes from triggering unrelated test jobs. ChangesSecurity Vulnerability Reporting Setup
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/pr.yaml (1)
146-180:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd
!SECURITY.mdtotest_javachanged-files exclusions.
test_javais the only targeted group missing this exclusion, so a SECURITY.md-only PR can still trigger Java CI unexpectedly.Suggested patch
test_java: - '**' @@ - '!Dockerfile' + - '!SECURITY.md' - '!docs/**'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/pr.yaml around lines 146 - 180, Add the missing '!SECURITY.md' exclusion to the test_java changed-files list in the GitHub Actions PR workflow; update the test_java block in .github/workflows/pr.yaml (the list that currently includes entries like '!.coderabbit.yaml', '!.github/CODEOWNERS', '!Dockerfile', etc.) to include '!SECURITY.md' so SECURITY.md-only PRs no longer trigger the Java CI group.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/pr.yaml:
- Around line 146-180: Add the missing '!SECURITY.md' exclusion to the test_java
changed-files list in the GitHub Actions PR workflow; update the test_java block
in .github/workflows/pr.yaml (the list that currently includes entries like
'!.coderabbit.yaml', '!.github/CODEOWNERS', '!Dockerfile', etc.) to include
'!SECURITY.md' so SECURITY.md-only PRs no longer trigger the Java CI group.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6f2c3fe9-757a-4295-9b31-5ab7b10389fe
📒 Files selected for processing (3)
.github/CODEOWNERS.github/workflows/pr.yamlSECURITY.md
Description
Contributes to rapidsai/build-planning#281
SECURITY.mddescribing how to report security vulnerabilitiesNotes for Reviewers
Why not just set this org-wide?
An org-wide default is set at https://github.com/rapidsai/.github/blob/main/SECURITY.md, but adding an actual file in each repo offers a few benefits:
This can be admin-merged
I'll stop CI intentionally after
pre-commitruns, to save CI time and resources.