Add missing visibility controls in IVF SQ

[divyegala]

No description provided.

[coderabbitai]

Actionable comments posted: 0

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 88701716-01c5-4626-aee5-66c1f3d825fa

📥 Commits

Reviewing files that changed from the base of the PR and between 8408b45 and e293e61.

📒 Files selected for processing (2)

• c/include/cuvs/neighbors/ivf_sq.h
• cpp/include/cuvs/neighbors/ivf_sq.hpp

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Enhanced library symbol export management across core neighbor search components. Ensures consistent visibility and proper symbol resolution across different compilation units and platforms.

Walkthrough

The PR adds export visibility macros to the IVF-SQ neighbor search API headers. Both C and C++ headers now include their respective core export dependencies, and the C++ header restructures namespaces and marks template structs with CUVS_EXPORT to control public symbol visibility.

Changes

IVF-SQ API Export Visibility

Layer / File(s)	Summary
C API export header dependency c/include/cuvs/neighbors/ivf_sq.h	C header includes cuvs/core/export.h to support export macros.
C++ API export macro integration cpp/include/cuvs/neighbors/ivf_sq.hpp	C++ header includes cuvs/core/export.hpp, restructures namespaces using nested blocks with CUVS_EXPORT applied to the top-level cuvs namespace, and marks list_spec and index template structs with CUVS_EXPORT. Closing namespace comments are updated to match the new structure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• rapidsai/cuvs#2052: Both PRs update public API symbol visibility by introducing cuvs/core/export.(h|hpp) and applying CUVS_EXPORT to exported declarations.
• rapidsai/cuvs#1910: Main PR adjusts the IVF-SQ API headers to use cuvs/core/export macros, building on the IVF-SQ API introduced by this retrieved PR.

Suggested labels

improvement

Suggested reviewers

• robertmaynard

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether any description exists or is related to the changeset.	Add a description explaining why visibility controls were missing and what impact this change has on the library's public API.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding visibility controls (CUVS_EXPORT attributes) to IVF SQ header files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cjnolet]

/merge

[viclafargue]

Thanks a lot!