Skip to content

fix Auto-merge: Branch 23.08 merge 23.06#482

Merged
ajschmidt8 merged 4 commits intorapidsai:branch-23.08from
AjayThorve:branch-23.08-merge-23.06
Jun 1, 2023
Merged

fix Auto-merge: Branch 23.08 merge 23.06#482
ajschmidt8 merged 4 commits intorapidsai:branch-23.08from
AjayThorve:branch-23.08-merge-23.06

Conversation

@AjayThorve
Copy link
Copy Markdown
Member

Manually resolve conflicts in the auto-merge PR #481

AjayThorve and others added 3 commits May 31, 2023 16:36
This PR:
- fixes a couple of tests which were failing due to recent changes, leading to aggregate results being unsorted
- resolves docs build failures, which were caused by datashader rendering issues with latest numpy(1.24.3), fixed by adding a pin for numpy (<1.24, similar to the version pins in cugraph). @ajschmidt8, could you check if adding this version pin is fine?

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Allan (https://github.com/exactlyallan)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#479
Align with the rest of RAPIDS on these requirements. Also needed for CUDA 12 support.

Authors:
  - https://github.com/jakirkham
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Ajay Thorve (https://github.com/AjayThorve)

URL: rapidsai#480
…e every week (rapidsai#478)

Based on the discussion in rapidsai#452, adding a weekly schedule to run the external dependency testing workflow.

cc @exactlyallan @ajschmidt8

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#478
@AjayThorve AjayThorve requested review from a team as code owners May 31, 2023 21:02
@AjayThorve AjayThorve added the non-breaking Non-breaking change label May 31, 2023
@AjayThorve AjayThorve force-pushed the branch-23.08-merge-23.06 branch from 19ff4e1 to 30f54a7 Compare May 31, 2023 21:09
@github-actions github-actions bot removed the Python label May 31, 2023
@AjayThorve AjayThorve force-pushed the branch-23.08-merge-23.06 branch from 30f54a7 to 31cf579 Compare May 31, 2023 21:24
@AjayThorve AjayThorve changed the title Branch 23.08 merge 23.06 fix Auto-merge: Branch 23.08 merge 23.06 May 31, 2023
@ajschmidt8
Copy link
Copy Markdown
Member

@AjayThorve, it looks like a merge conflict turned up.

Can you rebase to pull in the latest changes?

@AjayThorve AjayThorve force-pushed the branch-23.08-merge-23.06 branch from 31cf579 to f27b2c5 Compare June 1, 2023 16:47
@github-actions github-actions bot removed the Python label Jun 1, 2023
@AjayThorve
Copy link
Copy Markdown
Member Author

@AjayThorve, it looks like a merge conflict turned up.

Can you rebase to pull in the latest changes?

done

@ajschmidt8
Copy link
Copy Markdown
Member

@AjayThorve, I don't think that worked as intended.

This PR should have one more commit than the number of commits in the conflicted PR (#481).

Since that PR has 3 commits, this PR should have those commits plus one more commit for the merge conflicts (so 4 total commits).

@AjayThorve AjayThorve force-pushed the branch-23.08-merge-23.06 branch from f27b2c5 to 5a46979 Compare June 1, 2023 17:26
@AjayThorve AjayThorve force-pushed the branch-23.08-merge-23.06 branch from 5a46979 to c17e0d0 Compare June 1, 2023 17:29
@ajschmidt8 ajschmidt8 changed the base branch from branch-23.06 to branch-23.08 June 1, 2023 17:31
@ajschmidt8 ajschmidt8 merged commit 5fb6463 into rapidsai:branch-23.08 Jun 1, 2023
@AjayThorve AjayThorve deleted the branch-23.08-merge-23.06 branch June 1, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci conda doc Documentation non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants