Skip to content

[REVIEW] Backport TLS files missing fix#321

Merged
raydouglass merged 2 commits intorapidsai:masterfrom
raydouglass:tls-fix-backport
Jun 22, 2020
Merged

[REVIEW] Backport TLS files missing fix#321
raydouglass merged 2 commits intorapidsai:masterfrom
raydouglass:tls-fix-backport

Conversation

@raydouglass
Copy link
Copy Markdown
Contributor

This is just a backport of #320 to v0.14

@raydouglass raydouglass added the 3 - Ready for Review Ready for review by team label Jun 22, 2020
@raydouglass raydouglass requested a review from a team as a code owner June 22, 2020 14:49
@raydouglass raydouglass self-assigned this Jun 22, 2020
Copy link
Copy Markdown
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @raydouglass !

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f6fe329). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #321   +/-   ##
=========================================
  Coverage          ?   59.46%           
=========================================
  Files             ?       16           
  Lines             ?     1283           
  Branches          ?        0           
=========================================
  Hits              ?      763           
  Misses            ?      520           
  Partials          ?        0           
Impacted Files Coverage Δ
dask_cuda/dask_cuda_worker.py 79.83% <66.66%> (ø)
dask_cuda/local_cuda_cluster.py 82.50% <0.00%> (ø)
dask_cuda/utils.py 88.23% <0.00%> (ø)
dask_cuda/device_host_file.py 100.00% <0.00%> (ø)
dask_cuda/explicit_comms/comms.py 98.97% <0.00%> (ø)
dask_cuda/benchmarks/utils.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cupy_transpose_sum.py 0.00% <0.00%> (ø)
dask_cuda/explicit_comms/__init__.py 100.00% <0.00%> (ø)
dask_cuda/__init__.py 100.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cudf_merge.py 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6fe329...a860a1b. Read the comment docs.

@jakirkham
Copy link
Copy Markdown
Member

Thanks Ray! 😀

@pentschev, could you please take a look? 🙂

@pentschev
Copy link
Copy Markdown
Member

I did approve it already @jakirkham . 😄

@jakirkham
Copy link
Copy Markdown
Member

Ah sorry. 😞 On my phone and it doesn’t always show these things.

Thanks Peter 😀

@raydouglass raydouglass merged commit 43de9b2 into rapidsai:master Jun 22, 2020
@jakirkham jakirkham mentioned this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants