Skip to content

Use token.rapids.nvidia.com when issuing S3 bucket creds in devcontainers#105

Merged
trxcllnt merged 1 commit intorapidsai:mainfrom
trxcllnt:fea/use-rapids-token-service-in-devcontainers
May 1, 2026
Merged

Use token.rapids.nvidia.com when issuing S3 bucket creds in devcontainers#105
trxcllnt merged 1 commit intorapidsai:mainfrom
trxcllnt:fea/use-rapids-token-service-in-devcontainers

Conversation

@trxcllnt
Copy link
Copy Markdown
Contributor

Set AWS_IDP_URL and update AWS_ROLE_ARN to use token.rapids.nvidia.com

@trxcllnt trxcllnt requested a review from a team as a code owner April 30, 2026 17:33
@trxcllnt trxcllnt requested a review from AyodeAwe April 30, 2026 17:33
@trxcllnt trxcllnt added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Apr 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3146509c-7e02-4264-97e3-1fdfa8f68005

📥 Commits

Reviewing files that changed from the base of the PR and between e520996 and 94e6b37.

📒 Files selected for processing (1)
  • .devcontainer/Dockerfile

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated development environment configuration for build infrastructure authentication.

Walkthrough

The Dockerfile's sccache AWS authentication configuration is updated by switching the IAM role from nv-gha-token-sccache-devs to rapids-token-sccache-devs and introducing a new environment variable AWS_IDP_URL pointing to the RAPIDS token service endpoint.

Changes

Cohort / File(s) Summary
Sccache AWS Configuration
.devcontainer/Dockerfile
Updated AWS_ROLE_ARN to use rapids-token-sccache-devs role and added AWS_IDP_URL environment variable for token service authentication.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating AWS authentication configuration in devcontainers to use token.rapids.nvidia.com.
Description check ✅ Passed The description is directly related to the changeset, specifying the AWS configuration updates being made (AWS_IDP_URL and AWS_ROLE_ARN).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@hcho3
Copy link
Copy Markdown
Contributor

hcho3 commented May 1, 2026

/merge

@hcho3
Copy link
Copy Markdown
Contributor

hcho3 commented May 1, 2026

@rapidsai/packaging-codeowners Can I get a merge for this pull request?

@trxcllnt trxcllnt merged commit 2e39962 into rapidsai:main May 1, 2026
41 checks passed
@trxcllnt trxcllnt deleted the fea/use-rapids-token-service-in-devcontainers branch May 1, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants