enforce tighter wheel-size limits in CI#26
Merged
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom Jan 15, 2026
Merged
Conversation
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jameslamb
changed the title
hcho3
approved these changes
Jan 15, 2026
Contributor
|
/merge |
KyleFromNVIDIA
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project is still using cuML's wheel size limits, which allow
libcuforestwheels to be up to 525 MB.They're currently much smaller, so this proposes tighter limits to ensure we catch accidental binary size increases.
Notes for Reviewers
CUDA 13 wheels are expected to be smaller than CUDA 12, because of improvements in
nvccthat are only available in CUDA 13.The changes I'm proposing in
validate_wheel.shcontain a pattern I'd like to roll out across RAPIDS eventually in rapidsai/build-planning#219I got the current limits from this recent CI job: https://github.com/rapidsai/cuforest/actions/runs/20866479230/job/59959275775
cuforestwheels are under 1 MB so I didn't think it was worthwhile to have separate logic in a script for them. They can share the same threshold inpyproject.toml.