wheel builds: react to changes in pip's handling of build constraints#33
Merged
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom Jan 20, 2026
Merged
Conversation
mmccarty
added
improvement
jameslamb
reviewed
Jan 16, 2026
Member
|
/ok to test |
jameslamb
approved these changes
Jan 20, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Looks good. Double-checked logs and we seem to be getting what we want... no pip deprecation warnings and 100% cache hit rate building libcuforest.
Thanks!
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#242
Modifying
ci/build_wheel.shto--build-constraint="${PIP_CONSTRAINT}"unless build isolation is enabled.PIP_CONSTRAINT(set by rapids-init-pip)... it doesn't affect builds as of pip 25.3, and results in an error frompip wheelwhen set and--build-constraintis also passed