refactor update-version.sh to handle new branching strategy#42
refactor update-version.sh to handle new branching strategy#42rapids-bot[bot] merged 6 commits intorapidsai:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
| # Python version updates (pyproject.toml, version files) | ||
| for FILE in python/*/pyproject.toml; do | ||
| sed_runner "s/version = \".*\"/version = \"${NEXT_FULL_TAG}\"/g" "${FILE}" | ||
| sed_runner "s/^version = \".*\"/version = \"${NEXT_FULL_TAG}\"/g" "${FILE}" |
There was a problem hiding this comment.
Without this ^, this ends up overwriting any line containing version, like these:
| sed_runner "s/cuforest==.*/cuforest==${NEXT_SHORT_TAG}.*,>=0.0.0a0/g" dependencies.yaml | ||
| sed_runner "s/libcuforest==.*/libcuforest==${NEXT_SHORT_TAG}.*,>=0.0.0a0/g" dependencies.yaml | ||
| sed_runner "s/libcuforest-tests==.*/libcuforest-tests==${NEXT_SHORT_TAG}.*,>=0.0.0a0/g" dependencies.yaml | ||
| DEPENDENCIES=( |
There was a problem hiding this comment.
Let's use the pattern every other RAPIDS project uses here, which:
- does not differentiate between from-this-repo and other RAPIDs packages
- accounts for
-cu{12,13}suffixes in wheel names (this script previously missed those) - uses the PEP 440 versions for Python packages (
26.6.0, not26.06.0)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request refactors the release version update script with improved CLI argument parsing, validation, and version normalization logic. It also applies a coordinated version bump from 26.04.* to 26.4.* across all conda environment files, central dependencies manifest, and Python project configurations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
gforsyth
left a comment
There was a problem hiding this comment.
Approving with one question
|
|
||
| echo "Preparing release $CURRENT_TAG => $NEXT_FULL_TAG" | ||
| # Need to distutils-normalize the original version | ||
| NEXT_SHORT_TAG_PEP440=$(python -c "from packaging.version import Version; print(Version('${NEXT_SHORT_TAG}'))") |
There was a problem hiding this comment.
Did this get tested? Wouldn't `${NEXT_SHORT_TAG}' remain unexpanded due to the single quotes?
There was a problem hiding this comment.
Yep yep I did test this.
I think it gets expanded because the outermost quotes are double quotes.
$ NEXT_SHORT_TAG="26.04"
$ NEXT_SHORT_TAG_PEP440=$(python -c "from packaging.version import Version; print(Version('${NEXT_SHORT_TAG}'))")
$ echo ${NEXT_SHORT_TAG_PEP440}
26.4|
Thanks very much for the careful review! |
|
/merge |
Contributes to rapidsai/build-planning#224
Updates this repo to work with the new RAPIDS branching strategy.
update-version.sh(based on refactored update-version.sh to handle new branching strategy cuml#7455)pylibraft=26.4.0, notpylibraft=24.04.0), for consistency with the rest of RAPIDSNotes for Reviewers
How I tested this