Address comments in rapidsai/nvforest#35#46
Conversation
Co-Authored-By: Bradley Dice <bdice@bradleydice.com>
ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Free 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdates SPDX copyright header metadata in ci/build_docs.sh and excludes the file from pre-commit copyright verification checks via configuration update. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
| @@ -1,5 +1,5 @@ | |||
| #!/bin/bash | |||
| # SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
This is a mistake on my end. The file is original so its year should start with 2026.
| exclude: | | ||
| (?x)^( | ||
| ci/build_docs[.]sh | ||
| ) |
There was a problem hiding this comment.
This is to correct the copyright year of ci/build_docs.sh. It should be removed in a follow-up PR.
There was a problem hiding this comment.
Oh interesting, ok let's see if that works! I think it could. If it doesn't, take a look at the source code here: https://github.com/rapidsai/pre-commit-hooks/blob/main/src/rapids_pre_commit_hooks/copyright.py
| exclude: | | ||
| (?x)^( | ||
| ci/build_docs[.]sh | ||
| ) |
There was a problem hiding this comment.
Oh interesting, ok let's see if that works! I think it could. If it doesn't, take a look at the source code here: https://github.com/rapidsai/pre-commit-hooks/blob/main/src/rapids_pre_commit_hooks/copyright.py
|
/merge |
Address #35 (review)