Skip to content

Address comments in rapidsai/nvforest#35#46

Merged
rapids-bot[bot] merged 5 commits intorapidsai:mainfrom
hcho3:update_docs_build
Feb 27, 2026
Merged

Address comments in rapidsai/nvforest#35#46
rapids-bot[bot] merged 5 commits intorapidsai:mainfrom
hcho3:update_docs_build

Conversation

@hcho3
Copy link
Copy Markdown
Contributor

@hcho3 hcho3 commented Feb 20, 2026

Address #35 (review)

Co-Authored-By: Bradley Dice <bdice@bradleydice.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 20, 2026

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between dbc24e6 and 183e7be.

📒 Files selected for processing (2)
  • .pre-commit-config.yaml
  • ci/build_docs.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • .pre-commit-config.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated copyright header information in build scripts.
    • Modified build verification configuration to exclude build documentation scripts from copyright verification checks.

Walkthrough

Updates SPDX copyright header metadata in ci/build_docs.sh and excludes the file from pre-commit copyright verification checks via configuration update.

Changes

Cohort / File(s) Summary
Copyright Metadata Update
ci/build_docs.sh
SPDX copyright header year range changed from 2023-2026 to 2026.
Pre-commit Configuration
.pre-commit-config.yaml
Added exclude pattern to verify-copyright hook to skip copyright verification for ci/build_docs.sh using multiline regex.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread ci/build_docs.sh
@@ -1,5 +1,5 @@
#!/bin/bash
# SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mistake on my end. The file is original so its year should start with 2026.

@hcho3 hcho3 added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Feb 24, 2026
@hcho3 hcho3 requested a review from a team as a code owner February 24, 2026 01:02
Comment thread .pre-commit-config.yaml
Comment on lines +104 to +107
exclude: |
(?x)^(
ci/build_docs[.]sh
)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to correct the copyright year of ci/build_docs.sh. It should be removed in a follow-up PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, ok let's see if that works! I think it could. If it doesn't, take a look at the source code here: https://github.com/rapidsai/pre-commit-hooks/blob/main/src/rapids_pre_commit_hooks/copyright.py

Comment thread .pre-commit-config.yaml
Comment on lines +104 to +107
exclude: |
(?x)^(
ci/build_docs[.]sh
)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, ok let's see if that works! I think it could. If it doesn't, take a look at the source code here: https://github.com/rapidsai/pre-commit-hooks/blob/main/src/rapids_pre_commit_hooks/copyright.py

@hcho3
Copy link
Copy Markdown
Contributor Author

hcho3 commented Feb 25, 2026

/merge

@hcho3 hcho3 changed the title Address comments in rapidsai/cuforest#35 Address comments in rapidsai/nvforest#35 Feb 25, 2026
@rapids-bot rapids-bot Bot merged commit afb6731 into rapidsai:main Feb 27, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants