refactor(limited api): add explicit wheel.py-api to pyproject.toml
#50
Conversation
ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Free 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
|
/merge |
Description
As part of rapidsai/build-planning#42 I added support for building limited API wheels and conda packages.
To enable a RAPIDS-wide bump of the lower-bound of the limited API version we use (currently
cp311), the flags that set these options are passed in via environment variables.This leads us to an issue where local developer builds, either in devcontainers or otherwise, will build without the limited API, unless devs have set an (otherwise unnecessary) environment variable.
So here, I set the
py-apiversion explicitly, so that local builds will always produce limited API wheels and so better reflect what we build and test in CI.We retain the ability to bump all of RAPIDS to a different
cp3xxvalue because the flag passed in by our scripts overrides the value set in thepyproject.toml. There may be short periods where the flags we are building with and the flags set inpyproject.tomldiffer, but that should happen infrequently at best.