Skip to content

refactor(limited api): add explicit wheel.py-api to pyproject.toml #50

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
gforsyth:explicit-wheel-py-api
Feb 25, 2026
Merged

refactor(limited api): add explicit wheel.py-api to pyproject.toml #50
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
gforsyth:explicit-wheel-py-api

Conversation

@gforsyth
Copy link
Copy Markdown
Contributor

Description

As part of rapidsai/build-planning#42 I added support for building limited API wheels and conda packages.

To enable a RAPIDS-wide bump of the lower-bound of the limited API version we use (currently cp311), the flags that set these options are passed in via environment variables.

This leads us to an issue where local developer builds, either in devcontainers or otherwise, will build without the limited API, unless devs have set an (otherwise unnecessary) environment variable.

So here, I set the py-api version explicitly, so that local builds will always produce limited API wheels and so better reflect what we build and test in CI.

We retain the ability to bump all of RAPIDS to a different cp3xx value because the flag passed in by our scripts overrides the value set in the pyproject.toml. There may be short periods where the flags we are building with and the flags set in pyproject.toml differ, but that should happen infrequently at best.

@gforsyth gforsyth requested a review from a team as a code owner February 25, 2026 17:06
@gforsyth gforsyth requested a review from msarahan February 25, 2026 17:06
@gforsyth gforsyth added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Feb 25, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 25, 2026

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between a6ae36a and 3bfe1fc.

📒 Files selected for processing (1)
  • python/cuforest/pyproject.toml

📝 Walkthrough

Walkthrough

Added a new wheel.py-api = "cp311" configuration entry under the [tool.scikit-build] section in the Python cuforest project's build configuration file. This is a single-line configuration addition to the pyproject.toml that specifies the Python API version for wheel building.

Changes

Cohort / File(s) Summary
Build Configuration
python/cuforest/pyproject.toml
Added wheel.py-api = "cp311" under [tool.scikit-build] section to configure the Python API version for wheel builds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@jameslamb jameslamb removed the request for review from msarahan February 25, 2026 18:29
@gforsyth
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 6f7bc8e into rapidsai:main Feb 25, 2026
51 checks passed
@gforsyth gforsyth deleted the explicit-wheel-py-api branch February 25, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants